RFR: 8371792: Refactor barrier loop tests out of TestIfMinMax [v3]

Emanuel Peter epeter at openjdk.org
Thu Nov 27 12:24:54 UTC 2025


On Thu, 27 Nov 2025 10:42:30 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Trivial cleanup to move tests out of a test class whose description does not match these tests
>
> Galder Zamarreño has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactored to compiler.gcbarriers package

Changes requested by epeter (Reviewer).

test/hotspot/jtreg/compiler/gcbarriers/TestMinMaxLongLoopBarrier.java line 42:

> 40:  * @summary Test that MinL/MaxL nodes are removed when GC barriers in loop
> 41:  * @library /test/lib /
> 42:  * @run driver compiler.c2.irTests.TestMinMaxLongLoopBarrier

I think you forgot to update the class path here. You should do this now that it is possible, it prevents errors with wrongly copied test class names ;)
Suggestion:

 * @run driver ${test.main.class}

-------------

PR Review: https://git.openjdk.org/jdk/pull/28385#pullrequestreview-3515012522
PR Review Comment: https://git.openjdk.org/jdk/pull/28385#discussion_r2568405841


More information about the hotspot-compiler-dev mailing list