RFR: 8371792: Refactor barrier loop tests out of TestIfMinMax [v3]
Galder Zamarreño
galder at openjdk.org
Fri Nov 28 09:40:26 UTC 2025
On Thu, 27 Nov 2025 12:21:35 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Galder Zamarreño has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Refactored to compiler.gcbarriers package
>
> test/hotspot/jtreg/compiler/gcbarriers/TestMinMaxLongLoopBarrier.java line 42:
>
>> 40: * @summary Test that MinL/MaxL nodes are removed when GC barriers in loop
>> 41: * @library /test/lib /
>> 42: * @run driver compiler.c2.irTests.TestMinMaxLongLoopBarrier
>
> I think you forgot to update the class path here. You should do this now that it is possible, it prevents errors with wrongly copied test class names ;)
> Suggestion:
>
> * @run driver ${test.main.class}
Good catch! Applied your suggestion as is
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28385#discussion_r2570996565
More information about the hotspot-compiler-dev
mailing list