RFR: 8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVectorSize=8 [v2]
erifan
duke at openjdk.org
Fri Oct 17 01:25:20 UTC 2025
On Thu, 16 Oct 2025 03:09:24 GMT, erifan <duke at openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add check if flag is available.
>
> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 38:
>
>> 36: * @summary test combining vector not operation with compare
>> 37: * @modules jdk.incubator.vector
>> 38: * @requires vm.opt.final.MaxVectorSize == "null" | vm.opt.final.MaxVectorSize >= 16
>
> Should be
> Suggestion:
>
> * @requires vm.opt.final.MaxVectorSize == "null" & vm.opt.final.MaxVectorSize >= 16
>
>
> or
> Suggestion:
>
> * @requires vm.compiler2.enabled & vm.opt.final.MaxVectorSize >= 16
>
> ?
>
> Assume this test is run with another compiler (like Graal) that doesn't support the option `MaxVectorSize`, then `vm.opt.final.MaxVectorSize == "null"` holds. But this can't guarantee that the max vector size >= 16.
I forgot to submit this comment. I thought I submitted it two days ago.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27805#discussion_r2437969594
More information about the hotspot-compiler-dev
mailing list