RFR: 8365732: RISC-V: implement AES CTR intrinsics [v11]

Andrew Haley aph at openjdk.org
Sat Oct 18 12:08:10 UTC 2025


On Sat, 18 Oct 2025 11:31:37 GMT, Anjian Wen <wenanjian at openjdk.org> wrote:

>> Hi everyone, please help review this patch which Implement the _counterMode_AESCrypt with Zvkned. On my QEMU, with Zvkned extension enabled, the tests in test/hotspot/jtreg/compiler/codegen/aes/ Passed.
>
> Anjian Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge branch 'openjdk:master' into aes_ctr
>  - add assertion and change test
>  - add zbb and zvbb check
>  - Merge branch 'openjdk:master' into aes_ctr
>  - Merge branch 'openjdk:master' into aes_ctr
>  - fix the counter increase at limit and add test
>  - change format
>  - update reg use and instruction
>  - change some name and format
>  - delete useless Label, change L_judge_used to L_slow_loop
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/eff6439e...716825a4

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 2626:

> 2624:   //
> 2625:   address generate_counterMode_AESCrypt() {
> 2626:     assert(UseAESCTRIntrinsics, "need AES instructions (Zvkned extension) support");

It's hard for anyone to understand the control flow. If you look at the same routine in the AArch64 port you'll see plenty of comments to help the reader.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25281#discussion_r2442332565


More information about the hotspot-compiler-dev mailing list