RFR: 8370225: RISC-V: cleanup verify_xxx in interp_masm_riscv.hpp [v2]

[Hamlin Li]

On Tue, 21 Oct 2025 10:45:43 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add NOT_DEBUG_RETURN
>
> src/hotspot/cpu/riscv/interp_masm_riscv.hpp line 306:
> 
>> 304:   void verify_access_flags(Register access_flags, uint32_t flag,
>> 305:                            const char* msg, bool stop_by_hit = true) NOT_DEBUG_RETURN;
>> 306:   void verify_frame_setup() NOT_DEBUG_RETURN;
> 
> OK. Then can you remove the surrounding ASSERT of the use sites for consistency? It becomes unnecessary after adding `NOT_DEBUG_RETURN`. One example:
> 
> 1075   // start execution
> 1076 #ifdef ASSERT
> 1077   __ verify_frame_setup();
> 1078 #endif

I think the `ASSERT`s around invocation of `verify_frame_setup` are already removed in this patch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27894#discussion_r2447677408