RFR: 8347463: jdk/jfr/threading/TestManyVirtualThreads.java crashes with assert(oopDesc::is_oop_or_null(val)) [v2]

Mon Oct 27 09:41:27 UTC 2025

On Mon, 27 Oct 2025 09:32:31 GMT, Anton Seoane Ampudia <aseoane at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/intrinsics/TestReturnsOopSetForJFRWriteCheckpoint.java line 29:
>> 
>>> 27: 
>>> 28: import jdk.jfr.Event;
>>> 29: import jdk.jfr.Name;
>> 
>> Unused, please remove.
>
> I think you mean just line 29? AFAIK we need the header and importing the basics for testing (line 29 is unused, yes)

Right, just line 29.

>> test/hotspot/jtreg/compiler/intrinsics/TestReturnsOopSetForJFRWriteCheckpoint.java line 38:
>> 
>>> 36:  * @requires vm.hasJFR & vm.continuations
>>> 37:  * @library /test/lib /
>>> 38:  * @modules jdk.jfr/jdk.jfr.internal
>> 
>> Do we need this?
>
> We don't. Removed as well!

(Referring to line 38 only).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27913#discussion_r2464990761
PR Review Comment: https://git.openjdk.org/jdk/pull/27913#discussion_r2464991906