RFR: 8370708: RISC-V: Add VerifyStackAtCalls [v3]

Fei Yang fyang at openjdk.org
Tue Oct 28 08:14:02 UTC 2025


On Tue, 28 Oct 2025 07:48:50 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> Sanity tested, running t1.
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Label name

src/hotspot/cpu/riscv/riscv.ad line 1375:

> 1373:   if (VerifyStackAtCalls) {
> 1374:     st->print("mv  t2, %ld\n\t", MAJIK_DWORD);
> 1375:     st->print("sd  t2, [sp, #%d]\n\t", - 3 * wordSize);

Hmm ... I missed this one. Shouldn't the offset of the address be: `framesize - 3 * wordSize`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2468361310


More information about the hotspot-compiler-dev mailing list