RFR: 8370708: RISC-V: Add VerifyStackAtCalls [v3]

Robbin Ehn rehn at openjdk.org
Tue Oct 28 09:19:09 UTC 2025


On Tue, 28 Oct 2025 08:11:15 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Label name
>
> src/hotspot/cpu/riscv/riscv.ad line 1375:
> 
>> 1373:   if (VerifyStackAtCalls) {
>> 1374:     st->print("mv  t2, %ld\n\t", MAJIK_DWORD);
>> 1375:     st->print("sd  t2, [sp, #%d]\n\t", - 3 * wordSize);
> 
> Hmm ... I missed this one. Shouldn't the offset of the address be: `framesize - 3 * wordSize`?

The two above is printed like:

  st->print("sd  fp, [sp, #%d]\n\t", - 2 * wordSize);
  st->print("sd  ra, [sp, #%d]\n\t", - wordSize);

I just followed that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2468643768


More information about the hotspot-compiler-dev mailing list