RFR: 8364305: Support AVX10 saturating floating point conversion instructions [v11]
Mohamed Issa
missa at openjdk.org
Thu Sep 11 23:10:58 UTC 2025
On Thu, 11 Sep 2025 17:20:29 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Mohamed Issa has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Check for instructions that shouldn't appear in vector floating point conversion tests
>> - Correctly calculate vector lengths and don't rely on VectorReinterpret in cast2F2X and cast2D2X memory instructions
>
> src/hotspot/cpu/x86/x86.ad line 7719:
>
>> 7717: is_integral_type(Matcher::vector_element_basic_type(n)));
>> 7718: match(Set dst (VectorCastF2X src));
>> 7719: format %{ "vector_cast2r_f2x $dst, $src\t!" %}
>
> Suggestion:
>
> format %{ "vector_cast_f2x_saturating $dst, $src\t!" %}
Updated
> src/hotspot/cpu/x86/x86.ad line 7732:
>
>> 7730: is_integral_type(Matcher::vector_element_basic_type(n)));
>> 7731: match(Set dst (VectorCastF2X (LoadVector src)));
>> 7732: format %{ "vector_cast2m_f2x $dst, $src\t!" %}
>
> Suggestion:
>
> format %{ "vector_cast_f2x_saturating $dst, $src\t!" %}
>
> src will be represented by appropriate addressing scheme for the memory operand
Updated
> src/hotspot/cpu/x86/x86.ad line 7793:
>
>> 7791: is_integral_type(Matcher::vector_element_basic_type(n)));
>> 7792: match(Set dst (VectorCastD2X src));
>> 7793: format %{ "vector_cast2r_d2x $dst, $src\t!" %}
>
> Suggestion:
>
> format %{ "vector_cast_d2x_saturating $dst, $src\t!" %}
Updated
> src/hotspot/cpu/x86/x86.ad line 7806:
>
>> 7804: is_integral_type(Matcher::vector_element_basic_type(n)));
>> 7805: match(Set dst (VectorCastD2X (LoadVector src)));
>> 7806: format %{ "vector_cast2m_d2x $dst, $src\t!" %}
>
> Suggestion:
>
> format %{ "vector_cast_d2x_saturating $dst, $src\t!" %}
Updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2342543956
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2342544232
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2342544450
PR Review Comment: https://git.openjdk.org/jdk/pull/26919#discussion_r2342544575
More information about the hotspot-compiler-dev
mailing list