RFR: 8367483: C2 crash in PhaseValues::type: assert(t != nullptr) failed: must set before get - missing notification for CastX2P(SubL(x, y))

[Benoît Maillard]

On Fri, 12 Sep 2025 08:34:45 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/gvn/MissedOptimizationWithCastX2PSubX.java line 1:
>> 
>>> 1: /*
>> 
>> There is a `compiler/igvn` test folder. I think this suits better than `c2/gvn`.
>
> Yes. We already have other missed optimization tests in `c2/gvn` though 😆 
> As always: quite a mess.

This makes sense, but I remember that in the past similar tests (for example `test/hotspot/jtreg/compiler/c2/TestEliminateRedundantConversionSequences.java`) were simply put in `c2`. Not sure what is the policy here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27249#discussion_r2343448150