RFR: 8367483: C2 crash in PhaseValues::type: assert(t != nullptr) failed: must set before get - missing notification for CastX2P(SubL(x, y))

[Christian Hagedorn]

On Fri, 12 Sep 2025 08:35:47 GMT, Benoît Maillard <bmaillard at openjdk.org> wrote:

>> Yes. We already have other missed optimization tests in `c2/gvn` though 😆 
>> As always: quite a mess.
>
> This makes sense, but I remember that in the past similar tests (for example `test/hotspot/jtreg/compiler/c2/TestEliminateRedundantConversionSequences.java`) were simply put in `c2`. Not sure what is the policy here.

Yes, indeed. We should probably move them as well at some point. And we should probably stick more to the convention to name tests "TestXYZ" to distinguish between helper classes and actual tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27249#discussion_r2343455094