RFR: 8361699: C2: assert(can_reduce_phi(n->as_Phi())) failed: Sanity: previous reducible Phi is no longer reducible before SUT [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Fri Sep 12 12:40:17 UTC 2025


On Thu, 11 Sep 2025 09:42:18 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert clean-up in EA. Make catch statements more specific in test case.
>
> src/hotspot/share/opto/escape.cpp line 3135:
> 
>> 3133:           Node* phi = use->ideal_node();
>> 3134:           if (phi->Opcode() == Op_Phi && reducible_merges.member(phi)) {
>> 3135:             if (!can_reduce_phi(phi->as_Phi())) {
> 
> Drive-by comment: I think the ifs should be merged

@JohnTortugo: this comment is marked as resolved in the PR but I cannot see any reply or actual code change, did you perhaps forget pushing the requested change?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27063#discussion_r2344117240


More information about the hotspot-compiler-dev mailing list