RFR: 8361699: C2: assert(can_reduce_phi(n->as_Phi())) failed: Sanity: previous reducible Phi is no longer reducible before SUT [v2]

[Cesar Soares Lucas]

On Fri, 12 Sep 2025 12:37:54 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> src/hotspot/share/opto/escape.cpp line 3135:
>> 
>>> 3133:           Node* phi = use->ideal_node();
>>> 3134:           if (phi->Opcode() == Op_Phi && reducible_merges.member(phi)) {
>>> 3135:             if (!can_reduce_phi(phi->as_Phi())) {
>> 
>> Drive-by comment: I think the ifs should be merged
>
> @JohnTortugo: this comment is marked as resolved in the PR but I cannot see any reply or actual code change, did you perhaps forget pushing the requested change?

Apologies, I clicked resolve and didn't see it later on. I'll push it as soon as I have some time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27063#discussion_r2349577410