RFR: 8325467: Support methods with many arguments in C2 [v27]
Emanuel Peter
epeter at openjdk.org
Fri Sep 19 09:42:37 UTC 2025
On Wed, 17 Sep 2025 09:52:34 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/arguments/TestMethodArguments.java line 120:
>>
>>> 118: Template.let("classpath", comp.getEscapedClassPathOfCompiledClasses()),
>>> 119: """
>>> 120: import java.util.Arrays;
>>
>> Personally, I would not indent this deeply. I know that the generated code will not have proper indentation, but that's no so bad. Readability of the Templates is more important I think. Subjective though.
>
> No strong opinion here, I just went with the eclipse-jdtls autoformatter defaults. The generated code does have fairly OK indentation (the indentation in the code does not add any actual indentation in the generated code). Let me know what you prefer and I'll update it.
I would prefer readability of the test, not the generated code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r2362332715
More information about the hotspot-compiler-dev
mailing list