RFR: 8327963: C2: fix construction of memory graph around Initialize node to prevent incorrect execution if allocation is removed [v12]

[Roland Westrelin]

On Fri, 19 Sep 2025 12:41:06 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 45 commits:
>> 
>>  - more
>>  - Merge branch 'master' into JDK-8327963
>>  - more
>>  - more
>>  - Merge branch 'master' into JDK-8327963
>>  - more
>>  - more
>>  - lambda return
>>  - lambda clean up
>>  - Merge branch 'master' into JDK-8327963
>>  - ... and 35 more: https://git.openjdk.org/jdk/compare/e16c5100...b701d03e
>
> src/hotspot/share/opto/multnode.cpp line 73:
> 
>> 71:   };
>> 72:   return apply_to_projs(filter, which_proj);
>> 73: }
> 
> Consider moving this implementation to `multnode.hpp`, perhaps next to that of `MultiNode::apply_to_projs(DUIterator_Fast& imax, DUIterator_Fast& i, Callback callback, uint which_proj)`,  for consistency.

Isn't it better practice to leave the implementation in the cpp file? It's not always possible because of templates so some of the related methods' implementation is in the hpp file but wouldn't we want to keep that to a minimum?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24570#discussion_r2368422480