RFR: 8327963: C2: fix construction of memory graph around Initialize node to prevent incorrect execution if allocation is removed [v12]

[Roberto Castañeda Lozano]

On Mon, 22 Sep 2025 13:32:13 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/multnode.cpp line 73:
>> 
>>> 71:   };
>>> 72:   return apply_to_projs(filter, which_proj);
>>> 73: }
>> 
>> Consider moving this implementation to `multnode.hpp`, perhaps next to that of `MultiNode::apply_to_projs(DUIterator_Fast& imax, DUIterator_Fast& i, Callback callback, uint which_proj)`,  for consistency.
>
> Isn't it better practice to leave the implementation in the cpp file? It's not always possible because of templates so some of the related methods' implementation is in the hpp file but wouldn't we want to keep that to a minimum?

Fair enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24570#discussion_r2375531130