RFR: 8364757: Missing Store nodes caused by bad wiring in PhaseIdealLoop::insert_post_loop [v2]

[Benoît Maillard]

On Tue, 16 Sep 2025 08:39:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comment about the is_member condition
>
> src/hotspot/share/opto/loopTransform.cpp line 1788:
> 
>> 1786:   // right after the execution of the inner CountedLoop.
>> 1787:   // We have to make sure that such stores in the post loop have the right memory inputs from the main loop
>> 1788:   if (loop->tail()->in(0)->is_BaseCountedLoopEnd()) {
> 
> Out of curiosity: when would this condition be false?

I don't think it is ever false, I just changed it to use `main_end` directly instead. Thanks for pointing it out!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27225#discussion_r2369228441