RFR: 8364757: Missing Store nodes caused by bad wiring in PhaseIdealLoop::insert_post_loop [v4]

Benoît Maillard bmaillard at openjdk.org
Tue Sep 23 07:37:40 UTC 2025


On Tue, 16 Sep 2025 08:36:25 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change naming as suggested
>
> src/hotspot/share/opto/loopTransform.cpp line 1679:
> 
>> 1677:       Node* next = out->fast_out(l);
>> 1678:       if (next->is_Mem() && next->in(MemNode::Memory) == out) {
>> 1679:         IdealLoopTree* output_loop = get_loop(get_ctrl(next));
> 
> I would keep the names for `next` and `output_loop` consistent. Maybe `next_loop`? Or just call them `use` and `use_loop`?

Good point, I have changed it to `use` and `use_loop`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27225#discussion_r2371440440


More information about the hotspot-compiler-dev mailing list