RFR: 8364757: Missing Store nodes caused by bad wiring in PhaseIdealLoop::insert_post_loop [v7]

[Benoît Maillard]

On Tue, 16 Sep 2025 09:11:32 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More comments
>
> Thanks for working on this @benoitmaillard !
> 
> And thanks for all the explanations.
> 
> It seems the missing Phi at the OuterStripMinedLoop are a decision that implies that Stores will just sort of "hang" between loop exit and SafePoint. That is now the new "invariant". Fine for now, but we may want to reconsider adding the Phi for the OuterStripMinedLoop eventually.
> 
> I have read through the PR, and was a little confused about names, so bear with my comments 😅 
> 
> On the algo level I was wondering if it is possible to have a chain of stores between the exit and SafePoint? Do you have such examples?

@eme64 Thanks a lot for your detailed comments, this is really helpful. I have tried to address all of them, let me you what you think once you get the chance.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27225#issuecomment-3324371206