RFR: 8364757: Missing Store nodes caused by bad wiring in PhaseIdealLoop::insert_post_loop [v7]

Benoît Maillard bmaillard at openjdk.org
Tue Sep 23 14:52:23 UTC 2025


On Tue, 16 Sep 2025 09:10:00 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More comments
>
> test/hotspot/jtreg/compiler/loopstripmining/MissingStoreAfterOuterStripMinedLoop.java line 77:
> 
>> 75:         a1.field = 0;
>> 76:         a2.field = 0;
>> 77:     }
> 
> Do the field stores both float out of the loop, and end up in a chain between exit and safepoint? Might be nice to add some comments to these tests so we can see what examples you already cover and if we might need some more.

Yes, the entire chain floats out of the loop (each store is moved successively). I have added some comments about the structure that we are trying expose, and changed the test slightly as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27225#discussion_r2372583728


More information about the hotspot-compiler-dev mailing list