RFR: 8373343: C2: verify AddP base input only set for heap addresses [v3]

[Roland Westrelin]

On Mon, 22 Dec 2025 07:23:34 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/graphKit.cpp line 3590:
> 
>> 3588:   }
>> 3589:   constant_value = Klass::_lh_neutral_value;  // put in a known value
>> 3590:   Node* lhp = basic_plus_adr(top(), klass_node, in_bytes(Klass::layout_helper_offset()));
> 
> Same thought here: could we have a separate `off_heap_plus_addr()` or something like that instead of passing in `top()` on each call site?
> 
> This and the other suggestion could also be done separately.

I gave that one a try and I found that pattern to be common and I think it would be best done as a separate change. WDYT?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28769#discussion_r2667477734