RFR: 8373343: C2: verify AddP base input only set for heap addresses [v3]

[Christian Hagedorn]

On Wed, 7 Jan 2026 08:18:25 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/graphKit.cpp line 3590:
>> 
>>> 3588:   }
>>> 3589:   constant_value = Klass::_lh_neutral_value;  // put in a known value
>>> 3590:   Node* lhp = basic_plus_adr(top(), klass_node, in_bytes(Klass::layout_helper_offset()));
>> 
>> Same thought here: could we have a separate `off_heap_plus_addr()` or something like that instead of passing in `top()` on each call site?
>> 
>> This and the other suggestion could also be done separately.
>
> I gave that one a try and I found that pattern to be common and I think it would be best done as a separate change. WDYT?

Sounds good, let's do it separately.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28769#discussion_r2672027289