RFR: 8375271: [IR Framework] Rename IREncoding to ApplicableIRRules and driver/flag/test VM to Driver/Flag/Test VM
Manuel Hässig
mhaessig at openjdk.org
Wed Jan 14 12:05:46 UTC 2026
On Wed, 14 Jan 2026 11:21:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
> This patch is part of a series of patches split of from a prototype implementation for replacing the hotspot-pid file based transfer of IR dumps between the Test VM and the Driver VM with a socket based transfer (see [JDK-8375271](https://bugs.openjdk.org/browse/JDK-8375271) for more information). This should ease reviews.
>
> This patch is about naming updates:
>
> `IREncoding` is quite generic and does not really tell what it is about by looking at its name. I suggest to rename it to `ApplicableIRRules` to better reflect what it is about. I also capitalized the first letter of "driver/flag/test VM" to better indicate that these are proper names.
>
> Thanks,
> Christian
Nice and straightforward, thank you @chhagedorn. I found two typos, otherwise this looks good.
test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 242:
> 240: * <ul>
> 241: * <li><p>The {@code flags} override any set VM or Javaoptions flags by JTreg by default.<p>
> 242: * Use {@code -DPreferCommandLineFlags=true} if you want to prefer the JTreg VM and Javaoptions flags over
Suggestion:
* Use {@code -DPreferCommandLineFlags=true} if you want to prefer the JTreg VM and Javaoptions flags over
Since you are modifying this comment, you might also remove this superfluous space.
test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java line 44:
> 42:
> 43: /**
> 44: * This class prepares, creates, and runs the "test" VM with verification of proper termination. The class also stores
Suggestion:
* This class prepares, creates, and runs the "Test" VM with verification of proper termination. The class also stores
You missed a capitalization
-------------
Marked as reviewed by mhaessig (Committer).
PR Review: https://git.openjdk.org/jdk/pull/29229#pullrequestreview-3660373869
PR Review Comment: https://git.openjdk.org/jdk/pull/29229#discussion_r2690158732
PR Review Comment: https://git.openjdk.org/jdk/pull/29229#discussion_r2690146222
More information about the hotspot-compiler-dev
mailing list