RFR: 8375271: [IR Framework] Rename IREncoding to ApplicableIRRules and driver/flag/test VM to Driver/Flag/Test VM [v2]
Christian Hagedorn
chagedorn at openjdk.org
Wed Jan 14 12:34:35 UTC 2026
On Wed, 14 Jan 2026 12:02:32 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update Test VM
>> - Update test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java
>>
>> Co-authored-by: Manuel Hässig <manuel at haessig.org>
>
> Nice and straightforward, thank you @chhagedorn. I found two typos, otherwise this looks good.
Thanks @mhaessig for your review! I pushed an update addressing your comments.
> test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java line 44:
>
>> 42:
>> 43: /**
>> 44: * This class prepares, creates, and runs the "test" VM with verification of proper termination. The class also stores
>
> Suggestion:
>
> * This class prepares, creates, and runs the "Test" VM with verification of proper termination. The class also stores
>
> You missed a capitalization
Good catch, changed it to Test VM instead.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29229#issuecomment-3749348074
PR Review Comment: https://git.openjdk.org/jdk/pull/29229#discussion_r2690245636
More information about the hotspot-compiler-dev
mailing list