RFR: 8370666: VectorAPI: Add clear comments for vector relative code in c2 [v3]

[Xiaohong Gong]

On Fri, 9 Jan 2026 13:32:54 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comments in type.cpp
>
> Nice work, thanks for taking the time for this, much appreciated!
> 
> On the whole I'm super happy with this, but left a few extra comments :)

Hi @eme64 , regarding to the comments, could you please take another look and check whether it's clear enough? Thanks so much for any feedback.

> src/hotspot/share/opto/vectornode.hpp line 1874:
> 
>> 1872: // Convert a "BVectMask" into a platform-specific vector mask (either "NVectMask"
>> 1873: // or "PVectMask").
>> 1874: class VectorLoadMaskNode : public VectorNode {
> 
> I'd love to rename this. Because it is (as you say in the comments) a conversion, and not a "load" (memory op).
> What about `VectorConvertBooleans2MaskNode`.
> 
> And below, rename `VectorStoreMaskNode` to `VectorConvertMask2BooleansNode`.
> 
> You may have an even better idea.

Hi @eme64 , do you have any insights on this? I’m wondering whether separating the renaming change into a different PR would be acceptable to you. Additionally, do think it's better that we start a dedicated thread on the mailing list or github to discuss this further and gather more feedback from others?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29130#issuecomment-3757989173
PR Review Comment: https://git.openjdk.org/jdk/pull/29130#discussion_r2696748738