RFR: 8370666: VectorAPI: Add clear comments for vector relative code in c2 [v3]

[Emanuel Peter]

On Fri, 16 Jan 2026 03:46:05 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.hpp line 1874:
>> 
>>> 1872: // Convert a "BVectMask" into a platform-specific vector mask (either "NVectMask"
>>> 1873: // or "PVectMask").
>>> 1874: class VectorLoadMaskNode : public VectorNode {
>> 
>> I'd love to rename this. Because it is (as you say in the comments) a conversion, and not a "load" (memory op).
>> What about `VectorConvertBooleans2MaskNode`.
>> 
>> And below, rename `VectorStoreMaskNode` to `VectorConvertMask2BooleansNode`.
>> 
>> You may have an even better idea.
>
> Hi @eme64 , do you have any insights on this? I’m wondering whether separating the renaming change into a different PR would be acceptable to you. Additionally, do think it's better that we start a dedicated thread on the mailing list or github to discuss this further and gather more feedback from others?

I'm fine with a separate RFE. Why not file an RFE, and then we can discuss on JIRA, and the PR that we will create from it? That will keep the conversation accessible to all and once the change is made people can find the conversation that led up to the change more easily :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29130#discussion_r2697451228