RFR: 8370666: VectorAPI: Add clear comments for vector relative code in c2 [v3]
Xiaohong Gong
xgong at openjdk.org
Fri Jan 16 09:18:01 UTC 2026
On Fri, 16 Jan 2026 08:53:13 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update comments in type.cpp
>
> src/hotspot/share/opto/vectornode.hpp line 57:
>
>> 55: // operations. While BVectMask primarily represents mask values loaded from or
>> 56: // stored to Java boolean memory, and is currently used in certain mask operations
>> 57: // (i.e. VectorMaskOpNode).
>
> You can also specify here that BVectMask representation is specifically tied to mask backing storage and VectorLoadMask and VectorStoreMask IR is needed to transform it to/from P/NVectMask
Thanks for looking at this PR. I added the mask type comment at the IR definition code in `vectornode.hpp` for these two IRs. Is that fine to you? Or we'd better comment here as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29130#discussion_r2697609026
More information about the hotspot-compiler-dev
mailing list