RFR: 8370666: VectorAPI: Add clear comments for vector relative code in c2 [v3]

Jatin Bhateja jbhateja at openjdk.org
Fri Jan 16 09:34:38 UTC 2026


On Fri, 16 Jan 2026 09:14:05 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.hpp line 57:
>> 
>>> 55: // operations. While BVectMask primarily represents mask values loaded from or
>>> 56: // stored to Java boolean memory, and is currently used in certain mask operations
>>> 57: // (i.e. VectorMaskOpNode).
>> 
>> You can also specify here that BVectMask representation is specifically tied to mask backing storage and VectorLoadMask and VectorStoreMask IR is needed to transform it to/from P/NVectMask
>
> Thanks for looking at this PR. I added the mask type comment  at the IR definition code in `vectornode.hpp` for these two IRs. Is that fine to you? Or we'd better comment here as well.

A mention here will complete the link b/w B and N/P representations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29130#discussion_r2697674507


More information about the hotspot-compiler-dev mailing list