RFR: 8375653: C2: CmpUNode::sub is not monotonic [v6]

[Quan Anh Mai]

> Hi,
> 
> This PR fixes the issue that `CmpUNode::sub` is not monotonic. The root cause is that it returns different values for several cases, but the cases are not mutually exclusive and the return values are not a subset of each other. This leads to the possibilities that a node satisfying both cases will return the first value, but if upon being widen it ceases to satisfy the first case but still satisfies the second case, the method will return the second value, which is not a superset of the previous result.
> 
> For example, given `r = CmpU(x, y)`.
> 
> At the first iteration, `type(x) = {0}` and `type(y) = {1, -1}`, then `CmpUNode::sub` returns `TypeInt::CC_LE` since it sees that `x` is the constant `0`.
> 
> At the second iteration, `type(x) = {0, 2}` and `type(y) = {-1, 1}`, then `CmpUNode::sub` returns `TypeInt::CC_NE` since it sees that `x` and `y` do not overlap. This is not a superset of `TypeInt::CC_LE`, which leads to an assertion.
> 
> Please take a look and leave your reviews, thanks a lot.

Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:

  style

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/29308/files
  - new: https://git.openjdk.org/jdk/pull/29308/files/625bed1c..053c5757

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=29308&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29308&range=04-05

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/29308.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29308/head:pull/29308

PR: https://git.openjdk.org/jdk/pull/29308