RFR: 8375653: C2: CmpUNode::sub is not monotonic [v5]

Quan Anh Mai qamai at openjdk.org
Fri Jan 23 08:51:54 UTC 2026


On Fri, 23 Jan 2026 08:40:48 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve IR tests
>
> src/hotspot/share/opto/subnode.cpp line 749:
> 
>> 747: // If both inputs are constants, compare them.
>> 748: const Type* CmpUNode::sub(const Type* t1, const Type* t2) const {
>> 749:   const TypeInt *r0 = t1->is_int();
> 
> We prefer `TypeInt* r0`. Same under.

Thanks, I missed that, fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29308#discussion_r2720273073


More information about the hotspot-compiler-dev mailing list