RFR: 8350330: C2: PhaseIdealLoop::add_parse_predicate() should mirror GraphKit::add_parse_predicate()
Quan Anh Mai
qamai at openjdk.org
Fri Jan 23 11:44:31 UTC 2026
On Thu, 22 Jan 2026 16:22:34 GMT, Roland Westrelin <roland at openjdk.org> wrote:
> `PhaseIdealLoop::add_parse_predicate()` was intented to mirror
> `GraphKit::add_parse_predicate()` but it doesn't. That last one checks
> `too_many_traps` per bci but the `PhaseIdealLoop` version doesn't. As
> demonstrated by the test case, a method can get compiled with a
> predicate, take a trap, and get recompiled with the same predicate
> many times (up to ~100).
LGTM, too.
-------------
Marked as reviewed by qamai (Committer).
PR Review: https://git.openjdk.org/jdk/pull/29367#pullrequestreview-3697117490
More information about the hotspot-compiler-dev
mailing list