RFR: 8350330: C2: PhaseIdealLoop::add_parse_predicate() should mirror GraphKit::add_parse_predicate() [v2]
Christian Hagedorn
chagedorn at openjdk.org
Tue Jan 27 16:04:20 UTC 2026
On Tue, 27 Jan 2026 15:44:43 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/longcountedloops/TestLoopNestTooManyTraps.java line 34:
>>
>>> 32: * -XX:-BackgroundCompilation -XX:-ShortRunningLongLoop -XX:-UseOnStackReplacement
>>> 33: * -XX:CompileOnly=*TestLoopNestTooManyTraps::test1 -XX:LoopMaxUnroll=0
>>> 34: * compiler.longcountedloops.TestLoopNestTooManyTraps
>>
>> Nice test! Would it make sense for this special test to also have a non-flag run?
>
> With no command line flag, the test fails because deoptimization doesn't happen when it expects. So the test would have to be tweaked so it can run in 2 modes (one with the command line flags and one without where some checks have to be relaxed). It doesn't feel like it's worth the effort.
Makes sense, then let's leave it as it is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29367#discussion_r2732730632
More information about the hotspot-compiler-dev
mailing list