RFR: 8375272: [IR Framework] Miscellaneous clean-ups

Damon Fenacci dfenacci at openjdk.org
Fri Jan 23 14:11:45 UTC 2026


On Thu, 22 Jan 2026 14:51:08 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> This patch applies various unrelated clean-ups split out from a first prototype for [JDK-8375270](https://bugs.openjdk.org/browse/JDK-8375270). This should ease reviews. I left some comments in the PR to further explain some details.
> 
> Thanks,
> Christian

Overall looks good. Thanks for the cleanup @chhagedorn! Just a couple of nits.

src/hotspot/share/opto/compile.cpp line 868:

> 866: #ifndef PRODUCT
> 867:   if (should_print_ideal()) {
> 868:     print_ideal_ir("PrintIdeal");

I guess this is for consistency as well, right?

test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java line 833:

> 831:      */
> 832:     private void runTests() {
> 833:         TreeMap<Long, String> durations = (PRINT_TIMES || VERBOSE) ? new TreeMap<>() : null;

Do we still need `VERBOSE` here?

-------------

PR Review: https://git.openjdk.org/jdk/pull/29362#pullrequestreview-3697591566
PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2721330432
PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2721288609


More information about the hotspot-compiler-dev mailing list