RFR: 8375272: [IR Framework] Miscellaneous clean-ups [v2]
Christian Hagedorn
chagedorn at openjdk.org
Fri Jan 23 14:52:27 UTC 2026
On Fri, 23 Jan 2026 14:04:17 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review Marc & Damon
>
> src/hotspot/share/opto/compile.cpp line 868:
>
>> 866: #ifndef PRODUCT
>> 867: if (should_print_ideal()) {
>> 868: print_ideal_ir("PrintIdeal");
>
> I guess this is for consistency as well, right?
Yes, exactly, that was the only reason.
> test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java line 833:
>
>> 831: */
>> 832: private void runTests() {
>> 833: TreeMap<Long, String> durations = (PRINT_TIMES || VERBOSE) ? new TreeMap<>() : null;
>
> Do we still need `VERBOSE` here?
Good catch! In the complete prototype fix, I removed `durations`. But for now it's correct to remove `VERBOSE` since `PRINT_TIMES` is already set when `VERBOSE` is also set.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2721508551
PR Review Comment: https://git.openjdk.org/jdk/pull/29362#discussion_r2721504122
More information about the hotspot-compiler-dev
mailing list