RFR: 8374622: StressIncrementalInlining should also randomize the processing order [v2]
Marc Chevalier
mchevalier at openjdk.org
Mon Jan 26 14:33:23 UTC 2026
On Tue, 20 Jan 2026 15:54:53 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:
>> As it says: randomize the order the late inlines are processed, and slightly factor it with macro nodes.
>>
>> I didn't add shuffle to the `GrowableArray` class since it seems a bit method specialized method (and it seems it'd be a controversial change to a widely use class), it would make `GrowableArray` depends on `Compile` for random number generation (or require a callback, for instance, giving a non-trivial signature and usage), I couldn't find other shuffling of such an object.
>> There is also shuffling of `UniqueNodeList` (for `StressIGVN`), but it seems hard to unify: access and length are not written quite the same, it would probably be not simpler than duplicating the implem (which is simple, so it's fine in my opinion).
>>
>> Thanks,
>> Marc
>
> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>
> Randomize insertion
I've did some randomization on insertion. It still seems fine in testing. Using this flag in tests causes a lot of failures and crash, but similar as before the shuffling. Some issues have been filed.
I suggest we keep the shuffling for the stress flag, and to create an followup issue to remove `AlwaysIncrementalInline` as it is subsumed (or should be) by the compile command `delayinline`. Is that fine for everyone?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29110#issuecomment-3799898012
More information about the hotspot-compiler-dev
mailing list