RFR: 8374622: StressIncrementalInlining should also randomize the processing order [v2]

Christian Hagedorn chagedorn at openjdk.org
Wed Jan 28 07:20:10 UTC 2026


On Tue, 20 Jan 2026 15:54:53 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> As it says: randomize the order the late inlines are processed, and slightly factor it with macro nodes.
>> 
>> I didn't add shuffle to the `GrowableArray` class since it seems a bit method specialized method (and it seems it'd be a controversial change to a widely use class), it would make `GrowableArray` depends on `Compile` for random number generation (or require a callback, for instance, giving a non-trivial signature and usage), I couldn't find other shuffling of such an object.
>> There is also shuffling of `UniqueNodeList` (for `StressIGVN`), but it seems hard to unify: access and length are not written quite the same, it would probably be not simpler than duplicating the implem (which is simple, so it's fine in my opinion).
>> 
>> Thanks,
>> Marc
>
> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Randomize insertion

We've also discussed it offline, I agree with your suggestion. Looks good!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29110#pullrequestreview-3714946353


More information about the hotspot-compiler-dev mailing list