RFR: 8350330: C2: PhaseIdealLoop::add_parse_predicate() should mirror GraphKit::add_parse_predicate() [v2]

[Roland Westrelin]

On Fri, 23 Jan 2026 07:37:19 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8350330
>>  - test & fix
>
> test/hotspot/jtreg/compiler/longcountedloops/TestLoopNestTooManyTraps.java line 34:
> 
>> 32:  *      -XX:-BackgroundCompilation -XX:-ShortRunningLongLoop -XX:-UseOnStackReplacement
>> 33:  *      -XX:CompileOnly=*TestLoopNestTooManyTraps::test1 -XX:LoopMaxUnroll=0
>> 34:  *      compiler.longcountedloops.TestLoopNestTooManyTraps
> 
> Nice test! Would it make sense for this special test to also have a non-flag run?

With no command line flag, the test fails because deoptimization doesn't happen when it expects. So the test would have to be tweaked so it can run in 2 modes (one with the command line flags and one without where some checks have to be relaxed). It doesn't feel like it's worth the effort.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29367#discussion_r2732651457