Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors

[Vladimir Kozlov]

No, these 2 methods arguments are the same.
I am not talking about renamed methods but these two:

class MatchNode {
    virtual void append_components(FormDict& locals, ComponentList& components,
                                   bool def_flag = false) const;
    virtual bool equivalent(FormDict& globals, MatchNode* mNode2);
}

class MatchRule: public MatchNode  {
    void       append_components(FormDict& locals, ComponentList& components, bool def_flag = false) 
const;
    bool       equivalent(FormDict& globals, MatchNode* mRule2);
}

In such situation C++ implicitly marks methods in MatchRule class as virtual also.
And I only asked to specify 'virtual' explicitly for these two methods.

Vladimir

Christian Thalinger wrote:
> On Wed, 2009-02-25 at 08:55 -0800, Vladimir Kozlov wrote:
>> Looks good.
>> In formssel.hpp I would mark MatchRule::append_components() and
>> MatchRule::equivalent() as virtual also.
> 
> I tried that but the arguments are different, so the subclass would
> shadow the superclass' methods.  I didn't find a solution.
> 
> -- Christian
>