Request for review (M): 6778669: Patch from Red Hat -- fixes compilation errors

Christian Thalinger Christian.Thalinger at Sun.COM
Thu Feb 26 01:30:42 PST 2009


On Wed, 2009-02-25 at 16:36 -0800, Vladimir Kozlov wrote:
> No, these 2 methods arguments are the same.
> I am not talking about renamed methods but these two:
> 
> class MatchNode {
>     virtual void append_components(FormDict& locals, ComponentList& components,
>                                    bool def_flag = false) const;
>     virtual bool equivalent(FormDict& globals, MatchNode* mNode2);
> }
> 
> class MatchRule: public MatchNode  {
>     void       append_components(FormDict& locals, ComponentList& components, bool def_flag = false) 
> const;
>     bool       equivalent(FormDict& globals, MatchNode* mRule2);
> }
> 
> In such situation C++ implicitly marks methods in MatchRule class as virtual also.
> And I only asked to specify 'virtual' explicitly for these two methods.

Ahh!  Sorry, I misunderstood that.  Yes, I will make them virtual
explicitly.  I will push it then.

-- Christian




More information about the hotspot-dev mailing list