Request for review (M): 6812587: Use auxv to determine SPARC hardware features on Solaris

Christian Thalinger Christian.Thalinger at Sun.COM
Wed Mar 4 11:24:03 PST 2009


On Wed, 2009-03-04 at 11:16 -0800, Tom Rodriguez wrote:
> Have you verified that this returns answers that are largely  
> consistent with the old results?

Yes, but I definitely could try a few more machines.

> Do we know whether AT_HWCAP is valid  
> and/or correctly set in earlier releases?  

Honestly, I don't know.  What is the oldest Solaris release we
officially support?

> The getisax code seems kind  
> of oddly coded.  The extra auxv_t seems useless since it's just set to  
> AT_NULL and never read.  I'd prefer if the result of the read were  
> checked against statb.st_size.  

Currently it's more or less the original getisax code.  I can change the
code.

> Shouldn't we use the real getisax if  
> it's available?

That would be the best way.  Should I add some dlsym logic?

-- Christian




More information about the hotspot-dev mailing list