Request for review (M): 6812587: Use auxv to determine SPARC hardware features on Solaris

[Tom Rodriguez]

On Mar 4, 2009, at 11:24 AM, Christian Thalinger wrote:

> On Wed, 2009-03-04 at 11:16 -0800, Tom Rodriguez wrote:
>> Have you verified that this returns answers that are largely
>> consistent with the old results?
>
> Yes, but I definitely could try a few more machines.

Maybe we should keep the old logic around in case getisax returns false?

>> Do we know whether AT_HWCAP is valid
>> and/or correctly set in earlier releases?
>
> Honestly, I don't know.  What is the oldest Solaris release we
> officially support?

Because of hotspot express we need to continue to support Solaris 8  
since that's the earliest release jdk 6 supports.

>> The getisax code seems kind
>> of oddly coded.  The extra auxv_t seems useless since it's just set  
>> to
>> AT_NULL and never read.  I'd prefer if the result of the read were
>> checked against statb.st_size.
>
> Currently it's more or less the original getisax code.  I can change  
> the
> code.
>
>> Shouldn't we use the real getisax if
>> it's available?
>
> That would be the best way.  Should I add some dlsym logic?

Yes.

tom