6348631 - request for review

Alan Bateman Alan.Bateman at oracle.com
Mon Nov 22 10:57:56 PST 2010


Ivan Krylov wrote:
> On 19.11.2010 13:33, Volker Simonis wrote:
>> What about the O_DELTE stuff? Is it really necessary. Additionally to
>> my comments, it is also not available in the Windows version of
>> os::open()!
>
> I am leaving this functionality unchanged with respect to the original 
> code on all operating systems.
AFAIK, the only place where it is used in the JDK is in j.u.zip.ZipFile 
where a zip file can be opened with a mode that includes 
ZipFile.OPEN_DELETE. It might be tricky to get that dependency removed 
in a timely manner from both jdk6 and jdk7. It might be good to include 
a comment as it's clearly a curiosity.  As regards Windows, I believe 
this is defined as O_TEMPORARY in jvm.h, which in turned is probably 
mapped by the Microsoft C runtime to the DELETE_ON_CLOSE flag (so no 
equivalent to the unlink required).

-Alan.


More information about the hotspot-dev mailing list