Review request:Updated JDK-8004728 Add hotspot support for parameter reflection

[Joel Borggrén-Franck]

On 12/19/2012 08:46 PM, Eric McCorkle wrote:
> Hello,
>
> I have made some nontrivial changes to the hotspot side of parameter
> reflection.  Please review again.
>
>
> The open webrev is here:
> http://oklahoma.us.oracle.com/~cphillim/webrev/eric.webrev2/
>

Hi Eric,

I looked over the code since I have been doing changes in the same area 
for type annotations. A few comments:

In vmSymbols.hpp:

239   template(executable_name,  "executable")

and

477   template(executable_signature, "Ljava/lang/reflect/executable;")

do you need to add these? if so shouldn't these be 'Executable' with a 
capital E? I noticed you add Parameter to systemDictionary.hpp but not 
Executable is this intentional?

jvm.cpp:

1580   // method is a handle to a java.lang.reflect.Method object
1581   Method* const m = jvm_get_method_common(method, CHECK_NULL)

Nit, I don't think this comment is correct in a non-permgen world.

cheers
/Joel