Review request:Updated JDK-8004728 Add hotspot support for parameter reflection

[Eric McCorkle]

On 12/20/12 04:11, Joel Borggrén-Franck wrote:

> Hi Eric,
> 
> I looked over the code since I have been doing changes in the same area
> for type annotations. A few comments:
> 
> In vmSymbols.hpp:
> 
> 239   template(executable_name,  "executable")
> 
> and
> 
> 477   template(executable_signature, "Ljava/lang/reflect/executable;")
> 
> do you need to add these? if so shouldn't these be 'Executable' with a
> capital E? I noticed you add Parameter to systemDictionary.hpp but not
> Executable is this intentional?

Sorry, you're looking at a slightly out of date version.  Look here:

http://cr.openjdk.java.net/~coleenp/JDK-8004728/

> 
> jvm.cpp:
> 
> 1580   // method is a handle to a java.lang.reflect.Method object
> 1581   Method* const m = jvm_get_method_common(method, CHECK_NULL)
> 
> Nit, I don't think this comment is correct in a non-permgen world.

That comment should go anyway.  That was to help me figure out the
meanings of the various different handles that exist.