Request for review 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field.

Keith McGuigan keith.mcguigan at oracle.com
Mon Oct 1 05:22:57 PDT 2012


Those lines in jni.cpp are bordering on "ludicrous" character length, 
IMO.  I know we don't have an hard-set character limit (much to my 
chagrin), but we should at least try to keep it reasonable to and close 
what else is in the surrounding code.  (My bad for not mentioning this 
eariler.)

The rest looks good to me.

--
- Keith

On 9/28/2012 9:29 AM, Coleen Phillimore wrote:
> Summary: Don't use HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N directly.
> Contributed-by: Mark Wielaard <mjw at redhat.com>
>
> I made a small change to dtrace.hpp to fix code for bsd when
> ENABLE_DTRACE is true, and moved the test.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/7170638/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=7170638
>
> Tested against nsk.dtrace.testlist and test in the patch.   Built on bsd.
>
> Thanks,
> Coleen


More information about the hotspot-dev mailing list