Request for review 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field.

Mark Wielaard mark at klomp.org
Mon Oct 1 11:20:32 PDT 2012


On Mon, 2012-10-01 at 08:22 -0400, Keith McGuigan wrote:
> Those lines in jni.cpp are bordering on "ludicrous" character length, 
> IMO.  I know we don't have an hard-set character limit (much to my 
> chagrin), but we should at least try to keep it reasonable to and close 
> what else is in the surrounding code.  (My bad for not mentioning this 
> eariler.)

Please feel free to add a \ line continuation before the second
DTRACE_PROBE macro on each line. That would still be ~100 character, but
that would be shorter than some of the surrounding code, and seems like
a "natural" break place. Normally I don't like such long lines either
and keep to < 76 so things fit nicely in my terminal window, but since
this file already had 160+ character lines I thought I would go with the
flow.

> The rest looks good to me.

Thanks,

Mark


More information about the hotspot-dev mailing list