Review request 8008310 - Some adjustments needed to, minimal VM warnings and errors for unsupported command line options

[Coleen Phillimore]

On 2/22/2013 5:35 PM, JOSEPH PROVINO wrote:
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8008310/webrev.01
>
> Thanks.
>
> joe

Joe, This is nice that you can exclude another file.   It would be 
better if filemap.hpp had less CDS_RETURNs.   Some of these inlined 
functions are only called from metaspaceShared.cpp so wouldn't have 
footprint in .text even if included.   I think there are only a couple 
that are called from outside metaspaceShared - which you already have 
excluded.

If someone says -Xshare:dump aka. -XX:+DumpSharedSpaces, I think this 
should return JNI_ERR.   A warning is good for the rest.

Thanks,
Coleen