Review request 8008310 - Some adjustments needed to, minimal VM warnings and errors for unsupported command line options

[David Holmes]

On 23/02/2013 8:35 AM, JOSEPH PROVINO wrote:
> Webrev is here: http://cr.openjdk.java.net/~jprovino/8008310/webrev.01

An explanation of what has been updated would be useful to the reader, 
and potential reviewers.

I agree with Colleen that -Xshare:dump should be a fatal error as 
dumping the shared archive is the only thing the VM is supposed to do in 
that case.

I'm also concerned about the filemap.hpp changes. This seems too 
extensive. If everything is conditional on CDS then shouldn't the whole 
file be excluded or at least ifdef'd to almost nothing? What is the 
client code for this? I would expect the client code to already be 
conditionalized on INCLUDE_CDS else it isn't going to work.

David

> Thanks.
>
> joe