Code review request: JDK-8000692,Remove old KERNEL code

[Coleen Phillimore]

Zhengyu,

This looks good.   Did you verify that it still builds the minimal1 vm 
and the minimal before/after sizes are the same?  Is there a minimal vm 
on windows?

On 1/18/2013 5:06 PM, Zhengyu Gu wrote:
> Hi Chris,
>
> Thanks for reviewing.
>
> On 1/18/2013 4:52 PM, Chris Plummer wrote:
>> make/windows/makefiles/vm.make: You missed the copyright update
>>
> Thanks.
>> src/share/vm/classfile/systemDictionary.cpp: I guess the removal of 
>> the following code is correct. The original code was odd since it had 
>> a kernel reference outside of #ifdef KERNEL, and then a non-kernel 
>> reference (which you removed), within the "if". Just want to double 
>> check that this is the right thing to do.

Yes, this can be removed.  It just meant that this class was optional 
and only supported with the kernel build.

Thanks for cleaning this up!
Coleen

>>
>> 1826   if (init_opt == SystemDictionary::Opt_Kernel) {
>> 1827 #ifndef KERNEL
>> 1828     try_load = false;
>> 1829 #endif //KERNEL
>> 1830   }
> I removed SystemDictionary::Opt_Kernel. Can anyone verify if it is OK?
>
>>
>> src/share/vm/prims/jniCheck.hpp: The #ifndef removal is correct, but 
>> not removing what is within the #ifndef.
>>
> Thanks,
>
> -Zhengyu
>
>> Chris
>>
>> On 1/18/13 12:00 PM, hotspot-dev-request at openjdk.java.net wrote:
>>> Hi,
>>>
>>> This is a cleanup of kernel code, since it is already obsoleted - JDK7
>>> and JDK8 are no longer building kernel.
>>>
>>> JBS:https://jbs.oracle.com/bugs/browse/JDK-8000692
>>> Webrev:http://cr.openjdk.java.net/~zgu/8000692/webrev.00/
>>>
>>> Tests:
>>>    - JPRT
>>>    - ute vm.quick.testlist on Linux x32.
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>