Review request for JDK-8006949: Update hotspot for MethodParameters format change

[Eric McCorkle]

I have posted a new webrev with code that is capable of loading
classfiles with both 2 and 4 byte flags fields.

Again, consider 4 byte flags fields to be temporary; *do not* count on
this ability in future versions.

On 01/28/13 18:04, Eric McCorkle wrote:
> I realized that I can detect when the flags are sized u4 versus u2 by
> looking at attribute_length.
> 
> I am modifying the patch to support *both* sizes; however, going
> forward, tools and implementations should only produce and consume u2.
> 
> I will post an updated webrev once I've run the end-to-end tests with
> both flavors.
> 
> On 01/28/13 16:47, Coleen Phillimore wrote:
>>
>> This is nice change to have the flags smaller.  The method parameter
>> tests are disabled and method parameters aren't found in the JDK
>> classfiles yet, so this will not fail with a version of the JDK that has
>> the flags as u4, right?
>>
>> Thanks,
>> Coleen
>>
>> On 01/28/2013 02:42 PM, Eric McCorkle wrote:
>>> Hello,
>>>
>>> Please review this patch, which updates hotspot in accordance with
>>> changes to the class file format of MethodParameters attributes.
>>>
>>> The latest spec version is here:
>>> http://cr.openjdk.java.net/~abuckley/8misc.pdf
>>>
>>> Any questions regarding the format change or the spec should be directed
>>> to Alex Buckley, the spec owner.
>>>
>>> The webrev is here:
>>> http://cr.openjdk.java.net/~emc/8006949/
>>>
>>> The enhancement request is here:
>>> http://bugs.sun.com/view_bug.do?bug_id=8006949
>>>
>>> The following CCC has been filed for this change:
>>> http://ccc.us.oracle.com/8006948
>>>
>>>
>>> The end-to-end tests for MethodParameters are presently disabled;
>>> however, I have run the end-to-end tests with this patch, as well as the
>>> companion patch for JDK-8006948, and seen no failures.
>>>
>>> I am presently running testlist and JPRT jobs; however, given the
>>> extremely small nature of the changeset, I do not anticipate seeing any
>>> failures.
>>>
>>> Thanks,
>>> Eric
>>